Iteration over SAM header lines and header expression filtering #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarshall
force-pushed
the
sam-header-expr
branch
from
daf9502
to
5af7995
Compare
jmarshall
force-pushed
the
sam-header-expr
branch
from
5af7995
to
33eefe8
Compare
Updated to a more final version of the proposed API names. Still needs some test cases probably… |
|
|
jmarshall
force-pushed
the
sam-header-expr
branch
from
33eefe8
to
7246ff3
Compare
jmarshall
force-pushed
the
sam-header-expr
branch
from
7246ff3
to
88586e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to add API functions allowing user code to iterate over all header lines in order. Then with a way of referencing a particular generic header line established, we can add a
sam_hdr_passes_filter()function to enable using filter expressions on SAM header lines.Draft because the proposed basic iteration API (and everything else) is still in flux: the
_line_in the names can probably be removed, and I am considering changing to C++-esquebegin/endterminology (which is an option for a SAM aux field iterator, and it would be good to use the same terminology for both) instead offirst/next.